Page MenuHomePhabricator
Differential D16156

Allow dialogs to opt in to being resizable
ClosedPublic
Actions

Authored by epriestley on Jun 21 2016, 12:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 12:47 AM
Unknown Object (File)
Sun, Apr 7, 7:53 PM
Unknown Object (File)
Fri, Mar 29, 7:50 PM
Unknown Object (File)
Mar 10 2024, 9:22 PM
Unknown Object (File)
Mar 4 2024, 1:41 PM
Unknown Object (File)
Feb 18 2024, 10:09 AM
Unknown Object (File)
Feb 18 2024, 10:09 AM
Unknown Object (File)
Feb 18 2024, 10:09 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4788: Allow "Edit Dependencies" both ways (blocking and depending)
T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier
Commits
rP3198aa1659ae: Allow dialogs to opt in to being resizable
Summary

Ref T11034. Ref T4788. This allows you to resize the typeahead browse dialog if you want. I plan to let you resize the object selector dialog in the future.

Test Plan

Screen Shot 2016-06-20 at 5.33.16 PM.png (1×1 px, 373 KB)

Diff Detail

Repository
rP Phabricator
Branch
resize1 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12748
Build 16220: Run Core Tests
Build 16219: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38867.Jun 21 2016, 12:34 AM
epriestley retitled this revision from to Allow dialogs to opt in to being resizable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier, T4788: Allow "Edit Dependencies" both ways (blocking and depending).
Herald edited edge metadata. · View Herald TranscriptJun 21 2016, 12:34 AM
epriestley added a comment.Jun 21 2016, 12:35 AM

We could also just auto-scale these to "90% of your screen" or whatever, but I like that they're dialog-sized by default.

epriestley added a comment.Jun 21 2016, 12:37 AM

this is real efficiency

Screen Shot 2016-06-20 at 5.37.03 PM.png (1×1 px, 219 KB)

chad accepted this revision.Jun 21 2016, 1:19 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2016, 1:19 AM
Closed by commit rP3198aa1659ae: Allow dialogs to opt in to being resizable (authored by epriestley, committed by epriestley). · Explain WhyJun 21 2016, 2:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
35 lines
src/
applications/
typeahead/
controller/
2 lines
view/
35 lines
webroot/
rsrc/
css/
aphront/
18 lines
externals/
javelin/
lib/
83 lines
image/

Diff 38867

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Workflow.js

Loading...
View Options

webroot/rsrc/image/resize.png

Loading...
Phabricator · Built by Phacility