Page MenuHomePhabricator

Render browse results with global result style
ClosedPublic

Authored by epriestley on Jun 20 2016, 9:03 PM.

Details

Summary

Ref T11034. This seems a little more promising. Two problems at the moment:

  • This doesn't actually provide any useful information at all right now.
  • Many object types have no profile images.
Test Plan

Screen Shot 2016-06-20 at 1.56.22 PM.png (446×622 px, 34 KB)

Screen Shot 2016-06-20 at 1.57.29 PM.png (470×637 px, 45 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Render browse results with global result style.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I'm sure I can clean up CSS.

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2016, 9:35 PM

Yeah, I think this one's the most promising. Let me get it filling in the information properly, at least.

epriestley edited edge metadata.
  • Handle objects with no profile better.
  • Fetch icon + title for users.
  • Fetch description for projects.
  • Show closed status / attributes.
  • Try to do something fairly reasonable for functions.

I probably missed a few and this could use some CSS, but I think it at least moves us in a reasonable direction:

Screen Shot 2016-06-20 at 4.47.10 PM.png (471×647 px, 40 KB)

This revision was automatically updated to reflect the committed changes.

Yeah I might try to swap "Select" with "View" and make the entire row the hit area?