Page MenuHomePhabricator

Remove the "you have not specified reviewers" prompt from the `arc` client
ClosedPublic

Authored by epriestley on Jun 17 2016, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:43 AM
Unknown Object (File)
Fri, Nov 15, 10:56 AM
Unknown Object (File)
Mon, Nov 11, 1:31 PM
Unknown Object (File)
Sat, Nov 9, 7:12 AM
Unknown Object (File)
Thu, Nov 7, 2:34 PM
Unknown Object (File)
Mon, Oct 28, 7:33 AM
Unknown Object (File)
Sun, Oct 27, 1:27 AM
Unknown Object (File)
Oct 12 2024, 9:02 AM
Subscribers
None
Tokens
"Like" token, awarded by avivey.

Details

Summary

Ref T4631. Ref T10939. I don't have any good solutions here; this is perhaps the least-bad one.

  • This prompt is misleading/confusing in the presence of Herald/Owners.
  • This prompt is likely of very little value for experienced reviewers.
  • When it works, this prompt may be of some value for new reviewers, but getting it wrong is probably more confusing than getting it right is helpful, and there is a more accurate version of the warning in the web UI that new users are likely to see.
  • In the long run, this code should not live in the client.
Test Plan

Created this revision without specifying reviewers, probably didn't get prompted.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove the "you have not specified reviewers" prompt from the `arc` client.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
Owners added a reviewer: Restricted Owners Package.Jun 17 2016, 2:52 PM
epriestley edited reviewers, added: chad; removed: Restricted Owners Package.Jun 17 2016, 2:53 PM

See significant discussion in T4631#181162.

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 17 2016, 3:03 PM
This revision was automatically updated to reflect the committed changes.