Differential D16135

Mark unreachable commits handles as "closed"
ClosedPublic
Actions

Authored by epriestley on Jun 16 2016, 6:52 PM.

Details

Reviewers

chad

Maniphest Tasks

T9028: Phabricator handles commits which are published and later deleted poorly

Commits

rP8032a142232d: Mark unreachable commits handles as "closed"

Summary

Ref T9028. Mostly, this gives them a strikethru style.

(I think this is probably the right definition of "closed" for commits. Another definition might be "audited", but I don't think completing audits really "closes" a commit.)

Test Plan

Screen Shot 2016-06-16 at 11.50.24 AM.png (511×619 px, 47 KB)

Diff Detail

Repository

rP Phabricator

Branch

ref7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12696
Build 16143: Run Core Tests
Build 16142: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38819.Jun 16 2016, 6:52 PM

epriestley retitled this revision from to Mark unreachable commits handles as "closed".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9028: Phabricator handles commits which are published and later deleted poorly.

chad accepted this revision.Jun 16 2016, 8:00 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2016, 8:00 PM

Closed by commit rP8032a142232d: Mark unreachable commits handles as "closed" (authored by epriestley, committed by epriestley). · Explain WhyJun 16 2016, 8:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

phid/

PhabricatorRepositoryCommitPHIDType.php

4 lines

Diff 38819

View Options

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

Mark unreachable commits handles as "closed"ClosedPublicActions