Differential D16128

Fix an issue with AuthProviderConfig handles
ClosedPublic
Actions

Authored by epriestley on Jun 16 2016, 10:46 AM.

Details

Reviewers

chad

Maniphest Tasks

T11156: Exception on auth configuration

Commits

rPf9e31089386c: Fix an issue with AuthProviderConfig handles

Summary

Fixes T11156. These were never correct, but also never actually used until I made timelines load object handles unconditionally in D16111.

Test Plan

Viewed an auth provider with transactions, no more fatal.

Diff Detail

Repository

rP Phabricator

Branch

provider1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12678
Build 16117: Run Core Tests
Build 16116: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38802.Jun 16 2016, 10:46 AM

epriestley retitled this revision from to Fix an issue with AuthProviderConfig handles.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11156: Exception on auth configuration.

epriestley mentioned this in T11156: Exception on auth configuration.Jun 16 2016, 10:46 AM

chad accepted this revision.Jun 16 2016, 1:04 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2016, 1:04 PM

Closed by commit rPf9e31089386c: Fix an issue with AuthProviderConfig handles (authored by epriestley, committed by epriestley). · Explain WhyJun 16 2016, 1:04 PM

This revision was automatically updated to reflect the committed changes.

• helladopee added a task: Restricted Maniphest Task.Jun 25 2016, 3:27 AM

chad removed a task: Restricted Maniphest Task.Jun 25 2016, 4:03 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

phid/

PhabricatorAuthAuthProviderPHIDType.php

6 lines

Diff 38802

View Options

src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php

Fix an issue with AuthProviderConfig handlesClosedPublicActions