Paths

Table of Contentst

Differential D16123

Support "x bits in bytes" in phutil_units()
ClosedPublic
Actions

Authored by epriestley on Jun 15 2016, 4:44 PM.

Details

Reviewers

chad

Maniphest Tasks

T11140: Support at-rest encryption in Files

Commits

rPHU1390fd2e8fdd: Support "x bits in bytes" in phutil_units()

Summary

Ref T11140. I need to generate some encryption keys to do at-rest encryption, and the code can be a little more readable as 256 bits in bytes, etc.

Test Plan

Unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

units

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/utils/utils.php:1294	XHP45	PHP Compatibility
Error	src/utils/utils.php:1294	XHP45	PHP Compatibility

Unit

Tests Passed

Build Status

Buildable 12667
Build 16098: Run Core Tests
Build 16097: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38791.Jun 15 2016, 4:44 PM

epriestley retitled this revision from to Support "x bits in bytes" in phutil_units().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11140: Support at-rest encryption in Files.

chad accepted this revision.Jun 15 2016, 5:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2016, 5:15 PM

Closed by commit rPHU1390fd2e8fdd: Support "x bits in bytes" in phutil_units() (authored by epriestley, committed by epriestley). · Explain WhyJun 15 2016, 6:18 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11140: Support at-rest encryption in Files.Jun 16 2016, 3:27 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUtilsTestCase.php

7 lines

utils.php

32 lines

Diff 38791

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

Support "x bits in bytes" in phutil_units()ClosedPublicActions