Page MenuHomePhabricator

Make PhameBlog full text searchable
ClosedPublic

Authored by chad on Jun 14 2016, 7:58 PM.
Tags
None
Referenced Files
F13130061: D16119.diff
Wed, May 1, 5:45 AM
F13123244: D16119.id38784.diff
Tue, Apr 30, 9:52 AM
Unknown Object (File)
Thu, Apr 25, 3:07 AM
Unknown Object (File)
Fri, Apr 19, 4:55 PM
Unknown Object (File)
Fri, Apr 12, 6:20 AM
Unknown Object (File)
Thu, Apr 11, 5:27 PM
Unknown Object (File)
Thu, Apr 11, 12:59 PM
Unknown Object (File)
Thu, Apr 11, 10:36 AM
Subscribers

Details

Summary

Ref T9897, makes blogs searchable

Test Plan

Make a blog, index it, search for it.

Diff Detail

Repository
rP Phabricator
Branch
PhameBlog-Search (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12660
Build 16087: Run Core Tests
Build 16086: arc lint + arc unit

Event Timeline

chad retitled this revision from to Make PhameBlog full text searchable.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2016, 8:11 PM
This revision was automatically updated to reflect the committed changes.

Oh, these might also need to implement supportsSearch() or whatever in the Editor classes. That should really become automatic if the object implements FulltextInterface, but currently isn't.

You can test by editing a blog/post to contain a unique word, then searching for it. If you fail to find it, check if supportsSearch() is implemented to return true;.

(That is, as long as the daemons are running, you shouldn't normally need to manually rebuild indexes for search results to reflect changes.)