Page MenuHomePhabricator

Add PhamePost to full text search
ClosedPublic

Authored by chad on Jun 14 2016, 6:23 PM.
Tags
None
Referenced Files
F15508004: D16116.id38779.diff
Wed, Apr 16, 12:56 AM
F15460224: D16116.id38780.diff
Mon, Mar 31, 9:08 PM
F15452068: D16116.id38780.diff
Sat, Mar 29, 1:30 AM
F15442845: D16116.id.diff
Thu, Mar 27, 12:50 AM
F15436625: D16116.diff
Mar 25 2025, 3:30 PM
F15429630: D16116.id38776.diff
Mar 24 2025, 3:22 AM
F15413486: D16116.diff
Mar 19 2025, 7:06 PM
Unknown Object (File)
Feb 16 2025, 6:59 AM
Subscribers

Details

Summary

Adds PhamePost object to fulltextsearch index. Some issue searching just "Open" though? Also "closed" objects search fine but don't display as disabled.

Test Plan

bin/search index --type POST

pasted_file (618×581 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Branch
PhamePost-Search (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12655
Build 16080: Run Core Tests
Build 16079: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add PhamePost to full text search.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

To fix open/closed, you likely need to add some logic to PhabricatorPhamePostPHIDType so handles get marked as closed. You can look at, e.g., ManiphestTaskPHIDType for an example.

I'll see if I can repro the "open documents" thing, not immediately sure about that...

chad planned changes to this revision.Jun 14 2016, 6:34 PM

roger roger

Searching just "open" seems OK for me -- here's "open + closed", note result 1 is archived:

Screen Shot 2016-06-14 at 11.34.34 AM.png (525×470 px, 43 KB)

Here's just "open", no longer returns the closed result:

Screen Shot 2016-06-14 at 11.34.39 AM.png (509×467 px, 40 KB)

chad edited edge metadata.
  • Add closed UI
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2016, 7:16 PM
This revision was automatically updated to reflect the committed changes.