Don't detect long sentences which happen to have a colon in them as Git URIs
ClosedPublic
Actions

Authored by epriestley on Jun 13 2016, 4:33 PM.

Details

Reviewers

Maniphest Tasks

T11137: Unable to update Git repositories with latest stable

Commits

rPHU0dca72380253: (stable) Don't detect long sentences which happen to have a colon in them as…
rPHUa815d2d850b8: Don't detect long sentences which happen to have a colon in them as Git URIs

Summary

Some very liberal code is currently trying to parse commit summaries aggressively as Git URIs, and leading to this:

Failed to parse URI "Summary: Ref T11137. This addresses three general issues:" as a Git URI.

Currently visible here:

https://secure.phabricator.com/rPHU8bb124c37de3dfa29fcd23d4be53a5696b705c81

Don't detect these as Git URIs.

Test Plan

Unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38742.Jun 13 2016, 4:33 PM

epriestley retitled this revision from to Don't detect long sentences which happen to have a colon in them as Git URIs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11137: Unable to update Git repositories with latest stable.

epriestley added a subscriber: 20after4.

chad accepted this revision.Jun 13 2016, 5:10 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 13 2016, 5:10 PM

Closed by commit rPHUa815d2d850b8: Don't detect long sentences which happen to have a colon in them as Git URIs (authored by epriestley, committed by epriestley). · Explain WhyJun 13 2016, 5:25 PM

Closed by commit rPHUa815d2d850b8: Don't detect long sentences which happen to have a colon in them as Git URIs (authored by epriestley, committed by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilURI.php

8 lines

__tests__/

PhutilURITestCase.php

4 lines

Diff 38750

View Options

src/parser/PhutilURI.php

View Options

src/parser/tests/PhutilURITestCase.php

Don't detect long sentences which happen to have a colon in them as Git URIsClosedPublicActions