Make base64 the default SMTP encoding
ClosedPublic
Actions

Authored by epriestley on Jun 9 2016, 8:19 PM.

Tags

None

Referenced Files

	F13151312: D16095.diff
	Sat, May 4, 6:29 PM

	F13149783: D16095.id38721.diff
	Sat, May 4, 11:20 AM

	F13149782: D16095.id38722.diff
	Sat, May 4, 11:20 AM

	Unknown Object (File)
	Wed, Apr 24, 11:22 PM

	Unknown Object (File)
	Wed, Apr 17, 3:46 PM

	Unknown Object (File)
	Thu, Apr 11, 7:52 AM

	Unknown Object (File)
	Wed, Apr 10, 12:18 AM

	Unknown Object (File)
	Sun, Apr 7, 7:45 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T11120: HTML mails malformed

Commits

rPc694bd651b49: Make base64 the default SMTP encoding

Summary

Ref T11120. If this works, I'll just remove this option completely.

Test Plan

¯\_(ツ)_/¯

Diff Detail

Repository

rP Phabricator

Branch

base64def

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12592
Build 15983: Run Core Tests
Build 15982: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38721.Jun 9 2016, 8:19 PM

epriestley retitled this revision from to Make base64 the default SMTP encoding.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11120: HTML mails malformed.

(ง'̀-'́)ง

This revision is now accepted and ready to land.Jun 9 2016, 8:20 PM

Remove one small "(default)" lie in documentation.

Closed by commit rPc694bd651b49: Make base64 the default SMTP encoding (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2016, 8:22 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11120: HTML mails malformed.Jul 8 2016, 2:20 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorPHPMailerConfigOptions.php

10 lines

Diff 38721

View Options

src/applications/config/option/PhabricatorPHPMailerConfigOptions.php

Make base64 the default SMTP encodingClosedPublicActions