Differential D16093

Change simple template dashboard to "Open Tasks" instead of "All Tasks"
ClosedPublic
Actions

Authored by epriestley on Jun 9 2016, 7:24 PM.

Details

Reviewers

chad

Commits

rPe6e4ddd03ab4: Change simple template dashboard to "Open Tasks" instead of "All Tasks"

Summary

"All Tasks" is bad in the long run and not clearly better for new installs.

Test Plan

Created a new smiple template, saw open tasks only.

Diff Detail

Repository

rP Phabricator

Branch

dashdefaul1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12589
Build 15978: Run Core Tests
Build 15977: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38718.Jun 9 2016, 7:24 PM

epriestley retitled this revision from to Change simple template dashboard to "Open Tasks" instead of "All Tasks".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

This still groups by status? Can it just be newest open?

Currently, we would have to either define a builtin query in Maniphest to do that, or change how the "Open Tasks" builtin query works.

chad accepted this revision.Jun 9 2016, 7:27 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 9 2016, 7:27 PM

(Not necessarily opposed to either of those, but maybe better to do as part of a larger revamp.)

Closed by commit rPe6e4ddd03ab4: Change simple template dashboard to "Open Tasks" instead of "All Tasks" (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2016, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Yeah, this is low hanging fruit.

And feel free to counterdiff me on anything else you want to change, you should be able to mess with the adjacent code pretty easily.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardEditController.php

4 lines

Diff 38718

View Options

src/applications/dashboard/controller/PhabricatorDashboardEditController.php

Change simple template dashboard to "Open Tasks" instead of "All Tasks"ClosedPublicActions