Give ConpherenceThreadQuery a primary table alias
ClosedPublic
Actions

Authored by epriestley on Jun 8 2016, 2:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T11113: Query error in Conpherence when searching for specific user

Commits

rPa653d4d9b3e1: Give ConpherenceThreadQuery a primary table alias

Summary

Fixes T11113. On the 2nd+ page, we could end up with an ambiguous id WHERE clause because we don't define a primary table alias on this query. Define one.

Test Plan

Changed SearchEngine to return pages of size 5, searched for my threads, toggled to second page, no exception.

Used DarkConsole to examine that second-page query, saw that it had thread.id explicitly instead of id implicitly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38689.Jun 8 2016, 2:37 PM

epriestley retitled this revision from to Give ConpherenceThreadQuery a primary table alias.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11113: Query error in Conpherence when searching for specific user.

chad accepted this revision.Jun 8 2016, 2:37 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2016, 2:37 PM

Closed by commit rPa653d4d9b3e1: Give ConpherenceThreadQuery a primary table alias (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2016, 2:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

query/

ConpherenceThreadQuery.php

16 lines

Diff 38690

View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Give ConpherenceThreadQuery a primary table aliasClosedPublicActions