Page MenuHomePhabricator
Differential D16079

Add print styles for Phortune carts
ClosedPublic
Actions

Authored by chad on Jun 8 2016, 3:51 AM.
Tags
None
Referenced Files
F13206830: D16079.diff
Wed, May 15, 6:17 PM
F13185750: D16079.diff
Sat, May 11, 3:11 AM
Unknown Object (File)
Tue, May 7, 5:39 AM
Unknown Object (File)
Fri, May 3, 3:25 AM
Unknown Object (File)
Mon, Apr 29, 2:54 PM
Unknown Object (File)
Fri, Apr 26, 11:10 PM
Unknown Object (File)
Wed, Apr 24, 10:50 PM
Unknown Object (File)
Mon, Apr 22, 2:44 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts
Commits
rP3453507230ed: Add print styles for Phortune carts
Summary

Fixes T10899, adds styles specifically for printing Phortune carts.

Test Plan

Print a Phortune cart

Diff Detail

Repository
rP Phabricator
Branch
print-css (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12561
Build 15938: Run Core Tests
Build 15937: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38687.Jun 8 2016, 3:51 AM
chad retitled this revision from to Add print styles for Phortune carts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 8 2016, 3:51 AM
chad updated this revision to Diff 38688.Jun 8 2016, 3:58 AM
  • derp
epriestley edited edge metadata.Jun 8 2016, 1:36 PM

Though, this doesn't actually work in my sandbox.

What's this part about?

epriestley accepted this revision.Jun 8 2016, 1:37 PM
epriestley edited edge metadata.

This seems fine for me locally.

This revision is now accepted and ready to land.Jun 8 2016, 1:37 PM
chad added a comment.Jun 8 2016, 1:41 PM

it was an older diff that didnt work.

we say to use !print in diviner, but it wouldn't transform the rule for me.

chad updated this object.Jun 8 2016, 1:41 PM
chad edited edge metadata.
Closed by commit rP3453507230ed: Add print styles for Phortune carts (authored by chad, committed by chad). · Explain WhyJun 8 2016, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
phortune/
controller/
2 lines
webroot/
rsrc/
css/
application/
phortune/
10 lines

Diff 38688

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phortune/controller/PhortuneCartViewController.php

Loading...
View Options

webroot/rsrc/css/application/phortune/phortune.css

Loading...
Phabricator · Built by Phacility