Differential D16077

Require login for "Must Verify Email" controller
ClosedPublic
Actions

Authored by epriestley on Jun 7 2016, 11:35 PM.

Details

Reviewers

chad

Commits

rPffb50ef45d1b: Require login for "Must Verify Email" controller

Summary

Via HackerOne. This page fatals if accessed directly while logged out.

The "shouldRequireLogin()" check is wrong; this is a logged-in page.

Test Plan

Viewed the page while logged out, no more fatal.

Faked my way through the actual verification flow.

Diff Detail

Repository

rP Phabricator

Branch

mustverify1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12556
Build 15930: Run Core Tests
Build 15929: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38683.Jun 7 2016, 11:35 PM

epriestley retitled this revision from to Require login for "Must Verify Email" controller.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Jun 7 2016, 11:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2016, 11:35 PM

Closed by commit rPffb50ef45d1b: Require login for "Must Verify Email" controller (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2016, 11:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

PhabricatorMustVerifyEmailController.php

4 lines

Diff 38683

View Options

src/applications/auth/controller/PhabricatorMustVerifyEmailController.php

Require login for "Must Verify Email" controllerClosedPublicActions