Page MenuHomePhabricator

Embed videos in Remarkup at actual size
ClosedPublic

Authored by epriestley on Jun 7 2016, 9:55 PM.
Tags
None
Referenced Files
F14789009: D16076.diff
Fri, Jan 24, 6:16 PM
Unknown Object (File)
Thu, Jan 23, 3:50 PM
Unknown Object (File)
Thu, Jan 23, 3:50 PM
Unknown Object (File)
Thu, Jan 23, 3:50 PM
Unknown Object (File)
Tue, Jan 21, 8:34 PM
Unknown Object (File)
Tue, Jan 21, 3:31 PM
Unknown Object (File)
Tue, Jan 21, 11:57 AM
Unknown Object (File)
Thu, Jan 16, 9:42 AM
Subscribers
None

Details

Summary

Ref T6916. Current rules tend to make videos gigantic. Just embed them at actual size, scaling them down if they're too big to fit.

Browsers generally provide some kind of "expand / fullscreen" element automatically anyway.

Test Plan

Viewed videos locally, saw them sized a little more reasonably.

Diff Detail

Repository
rP Phabricator
Branch
video2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12554
Build 15927: Run Core Tests
Build 15926: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Embed videos in Remarkup at actual size.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 9:58 PM
This revision was automatically updated to reflect the committed changes.