Page MenuHomePhabricator
Differential D16055

Very rough cut of prose diffs
ClosedPublic
Actions

Authored by epriestley on Jun 6 2016, 3:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:59 PM
Unknown Object (File)
Thu, Dec 19, 5:26 PM
Unknown Object (File)
Tue, Dec 17, 5:57 AM
Unknown Object (File)
Fri, Dec 13, 7:24 PM
Unknown Object (File)
Wed, Dec 11, 6:02 AM
Unknown Object (File)
Mon, Dec 9, 7:24 PM
Unknown Object (File)
Sat, Dec 7, 3:54 AM
Unknown Object (File)
Wed, Dec 4, 12:25 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T3353: Make Phriction Document changes reviewable
Commits
rPHUb3aa54fb9460: Very rough cut of prose diffs
Summary

Ref T3353. This is just sketching things out so I can wire them up. It probably doesn't do a particularly good job, but we can start refining it once it's hooked up the UI and we can catch problem cases.

Test Plan

Ran prosediff.php, got reasonable looking results for a simple test case:

Screen Shot 2016-06-06 at 7.59.37 AM.png (308×1 px, 126 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38630.Jun 6 2016, 3:01 PM
epriestley retitled this revision from to Very rough cut of prose diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T3353: Make Phriction Document changes reviewable.
epriestley updated this revision to Diff 38631.Jun 6 2016, 3:16 PM
  • Also combine runs of "++++", etc.
chad accepted this revision.Jun 6 2016, 7:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 7:10 PM
Closed by commit rPHUb3aa54fb9460: Very rough cut of prose diffs (authored by epriestley, committed by epriestley). · Explain WhyJun 6 2016, 7:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
utils/
50 lines
src/
4 lines
utils/
89 lines
92 lines

Diff 38636

View Options

scripts/utils/prosediff.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/utils/PhutilProseDiff.php

Loading...
View Options

src/utils/PhutilProseDifferenceEngine.php

Loading...
Phabricator · Built by Phacility