Page MenuHomePhabricator
Differential D16053

Log when daemons trigger a reload in response to config changes
ClosedPublic
Actions

Authored by epriestley on Jun 6 2016, 1:34 PM.
Tags
None
Referenced Files
F13087729: D16053.diff
Thu, Apr 25, 1:04 AM
Unknown Object (File)
Tue, Apr 23, 11:26 AM
Unknown Object (File)
Fri, Apr 19, 4:50 PM
Unknown Object (File)
Thu, Apr 18, 11:58 PM
Unknown Object (File)
Tue, Apr 9, 7:18 PM
Unknown Object (File)
Mon, Apr 8, 2:13 PM
Unknown Object (File)
Sun, Apr 7, 11:45 AM
Unknown Object (File)
Thu, Apr 4, 4:03 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10811: `phd-daemon` crash after automatic restart following config change
Commits
rPHU5e43755a5b58: Log when daemons trigger a reload in response to config changes
Summary

Ref T10811. This puts an explicit message in the log when a module triggers a reload.

  • Also, lift declare(ticks = 1) up to top level.
  • Make sure verbose messages hit the disk log, not just the database log.
Test Plan

Ran daemons, changed config, saw them reload automatically with an explicit message.

Diff Detail

Repository
rPHU libphutil
Branch
daemon1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12497
Build 15841: Run Core Tests
Build 15840: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38626.Jun 6 2016, 1:34 PM
epriestley retitled this revision from to Log when daemons trigger a reload in response to config changes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10811: `phd-daemon` crash after automatic restart following config change.
epriestley mentioned this in D16054: Lift ticks declaration to top level in Phabricator daemons.
chad accepted this revision.Jun 6 2016, 1:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 1:36 PM
Closed by commit rPHU5e43755a5b58: Log when daemons trigger a reload in response to config changes (authored by epriestley, committed by epriestley). · Explain WhyJun 6 2016, 1:39 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP0bf337b06c1f: Lift ticks declaration to top level in Phabricator daemons.

Revision Contents
Changeset List

PathSize
scripts/
daemon/
2 lines
src/
daemon/
15 lines
14 lines

Diff 38626

View Options

scripts/daemon/launch_daemon.php

Loading...
View Options

src/daemon/PhutilDaemonHandle.php

Loading...
View Options

src/daemon/PhutilDaemonOverseer.php

Loading...
Phabricator · Built by Phacility