Page MenuHomePhabricator

Log when daemons trigger a reload in response to config changes
ClosedPublic

Authored by epriestley on Jun 6 2016, 1:34 PM.
Tags
None
Referenced Files
F14962337: D16053.diff
Sun, Feb 16, 6:55 AM
Unknown Object (File)
Thu, Feb 13, 11:23 AM
Unknown Object (File)
Sun, Feb 9, 1:44 AM
Unknown Object (File)
Sun, Feb 9, 1:44 AM
Unknown Object (File)
Tue, Feb 4, 10:13 PM
Unknown Object (File)
Wed, Jan 29, 3:45 AM
Unknown Object (File)
Fri, Jan 24, 4:00 PM
Unknown Object (File)
Thu, Jan 23, 3:41 PM
Subscribers
None

Details

Summary

Ref T10811. This puts an explicit message in the log when a module triggers a reload.

  • Also, lift declare(ticks = 1) up to top level.
  • Make sure verbose messages hit the disk log, not just the database log.
Test Plan

Ran daemons, changed config, saw them reload automatically with an explicit message.

Diff Detail

Repository
rPHU libphutil
Branch
daemon1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12497
Build 15841: Run Core Tests
Build 15840: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Log when daemons trigger a reload in response to config changes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 1:36 PM