Page MenuHomePhabricator

When a task is removed from projects, remove its position on proxy columns for those projects
ClosedPublic

Authored by epriestley on Jun 5 2016, 11:01 PM.
Tags
None
Referenced Files
F13088438: D16052.diff
Thu, Apr 25, 1:26 AM
Unknown Object (File)
Sun, Apr 14, 8:27 AM
Unknown Object (File)
Sun, Mar 31, 12:36 AM
Unknown Object (File)
Thu, Mar 28, 8:41 PM
Unknown Object (File)
Thu, Mar 28, 8:01 PM
Unknown Object (File)
Thu, Mar 28, 7:50 PM
Unknown Object (File)
Thu, Mar 28, 7:33 PM
Unknown Object (File)
Thu, Mar 28, 2:10 PM
Subscribers
None

Details

Summary

Fixes T11088. When a task is removed from a project, we don't normally delete its column positions. If you accidentally remove a project and then restore the project, it's nice for the task to stay where you put it.

However, we do need to remove its positions in proxy columns to avoid the issue in T11088.

Test Plan
  • Added a failing unit test, made it pass.
  • Added a task to "X > Milestone 1", loaded workboard, used "Edit Projects" to move it to "X" instead, loaded workboard.
    • Before, it stayed in the "Milestone 1" column.
    • After, it moves to the "Backlog" column.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When a task is removed from projects, remove its position on proxy columns for those projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 11:05 PM
This revision was automatically updated to reflect the committed changes.