Page MenuHomePhabricator

Validate select/option settings more strictly when reading them
ClosedPublic

Authored by epriestley on Jun 5 2016, 5:25 PM.
Tags
None
Referenced Files
F15551837: D16047.id.diff
Sun, Apr 27, 6:46 PM
F15544885: D16047.diff
Sat, Apr 26, 7:37 AM
F15458363: D16047.id38611.diff
Mar 30 2025, 11:16 PM
F15446971: D16047.id.diff
Mar 27 2025, 9:08 PM
F15439547: D16047.diff
Mar 26 2025, 8:02 AM
F15438495: D16047.diff
Mar 26 2025, 1:03 AM
F15427097: D16047.diff
Mar 23 2025, 12:44 PM
F15415148: D16047.id38614.diff
Mar 20 2025, 4:23 AM
Subscribers
None

Details

Summary

Ref T4103. If the database has "" (empty string) for select/option settings, we can let that value be effective in the UI right now.

One consequence is that timestamps can vanish from the UI.

Instead, be stricter and discard it as an invalid value.

Test Plan
  • Forced time-format setting to ''.
  • Saw timestamps vanish before change.
  • Saw timestamps return to the default value after change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Validate select/option settings more strictly when reading them.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 5:25 PM
This revision was automatically updated to reflect the committed changes.