Page MenuHomePhabricator

Validate select/option settings more strictly when reading them
ClosedPublic

Authored by epriestley on Jun 5 2016, 5:25 PM.

Details

Summary

Ref T4103. If the database has "" (empty string) for select/option settings, we can let that value be effective in the UI right now.

One consequence is that timestamps can vanish from the UI.

Instead, be stricter and discard it as an invalid value.

Test Plan
  • Forced time-format setting to ''.
  • Saw timestamps vanish before change.
  • Saw timestamps return to the default value after change.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Validate select/option settings more strictly when reading them.Jun 5 2016, 5:25 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this revision to Diff 38611.
chad edited edge metadata.Jun 5 2016, 5:25 PM
chad accepted this revision.
This revision is now accepted and ready to land.Jun 5 2016, 5:25 PM
This revision was automatically updated to reflect the committed changes.