Validate select/option settings more strictly when reading them
ClosedPublic
Actions

Authored by epriestley on Jun 5 2016, 5:25 PM.

Details

Reviewers

chad

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rPc9ef7aeaa34a: Validate select/option settings more strictly when reading them

Summary

Ref T4103. If the database has "" (empty string) for select/option settings, we can let that value be effective in the UI right now.

One consequence is that timestamps can vanish from the UI.

Instead, be stricter and discard it as an invalid value.

Test Plan

Forced time-format setting to ''.
Saw timestamps vanish before change.
Saw timestamps return to the default value after change.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38611.Jun 5 2016, 5:25 PM

epriestley retitled this revision from to Validate select/option settings more strictly when reading them.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 5 2016, 5:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 5 2016, 5:25 PM

Closed by commit rPc9ef7aeaa34a: Validate select/option settings more strictly when reading them (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 5:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

setting/

PhabricatorSelectSetting.php

19 lines

Diff 38614

View Options

src/applications/settings/setting/PhabricatorSelectSetting.php

Validate select/option settings more strictly when reading themClosedPublicActions