Differential D16038

Modularize all the mail preferences
ClosedPublic
Actions

Authored by epriestley on Jun 4 2016, 11:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 31, 12:29 PM

	Unknown Object (File)
	Fri, Jan 31, 1:38 AM

	Unknown Object (File)
	Tue, Jan 28, 4:48 PM

	Unknown Object (File)
	Tue, Jan 28, 1:35 AM

	Unknown Object (File)
	Mon, Jan 27, 11:51 AM

	Unknown Object (File)
	Sat, Jan 25, 9:59 PM

	Unknown Object (File)
	Thu, Jan 23, 3:41 PM

	Unknown Object (File)
	Tue, Jan 21, 12:53 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rP7ef6c0a523fc: Modularize all the mail preferences

Summary

Ref T4103. This isn't completely perfect but should let us move forward without also expanding scope into "too much mail".

I split the existing "Mail Preferences" into two panels: a "Mail Delivery" panel for the EditEngine settings, and a "2000000 dropdowns" panel for the two million dropdowns. This one retains the old code more or less unmodified.

Test Plan

Ran unit tests, which cover most of this stuff.
Grepped for all removed constants.
Ran migrations, inspected database results.
Changed settings in both modified panels.
This covers a lot of ground, but anything I missed will hopefully be fairly obvious.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38588.Jun 4 2016, 11:23 PM

epriestley retitled this revision from to Modularize all the mail preferences.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 5 2016, 2:04 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 5 2016, 2:04 AM

Closed by commit rP7ef6c0a523fc: Modularize all the mail preferences (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 3:50 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12916: Email Settings and Email Preferences should maybe be the same panel.Jul 12 2017, 5:15 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160604.user.01.stringmailprefs.php

47 lines

src/

__phutil_library_map__.php

4 lines

applications/

feed/

PhabricatorFeedStoryPublisher.php

9 lines

metamta/

storage/

PhabricatorMetaMTAMail.php

142 lines

__tests__/

PhabricatorMetaMTAMailTestCase.php

60 lines

settings/

panel/

PhabricatorEmailDeliverySettingsPanel.php

24 lines

PhabricatorEmailPreferencesSettingsPanel.php

81 lines

setting/

PhabricatorEmailFormatSetting.php

4 lines

PhabricatorEmailNotificationsSetting.php

8 lines

PhabricatorEmailRePrefixSetting.php

4 lines

PhabricatorEmailSelfActionsSetting.php

8 lines

PhabricatorEmailTagsSetting.php

21 lines

PhabricatorEmailVarySubjectsSetting.php

6 lines

storage/

PhabricatorUserPreferences.php

12 lines

Diff 38604

resources/sql/autopatches/20160604.user.01.stringmailprefs.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/feed/PhabricatorFeedStoryPublisher.php

Loading...

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...

src/applications/metamta/storage/tests/PhabricatorMetaMTAMailTestCase.php

Loading...

src/applications/settings/panel/PhabricatorEmailDeliverySettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php

Loading...

src/applications/settings/setting/PhabricatorEmailFormatSetting.php

Loading...

src/applications/settings/setting/PhabricatorEmailNotificationsSetting.php

Loading...

src/applications/settings/setting/PhabricatorEmailRePrefixSetting.php

Loading...

src/applications/settings/setting/PhabricatorEmailSelfActionsSetting.php

Loading...

src/applications/settings/setting/PhabricatorEmailTagsSetting.php

Loading...

src/applications/settings/setting/PhabricatorEmailVarySubjectsSetting.php

Loading...

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...