Page MenuHomePhabricator

Modularize all the mail preferences
ClosedPublic

Authored by epriestley on Jun 4 2016, 11:23 PM.
Tags
None
Referenced Files
F15462847: D16038.id.diff
Tue, Apr 1, 6:07 PM
F15451163: D16038.id38588.diff
Fri, Mar 28, 8:32 PM
F15450162: D16038.id38604.diff
Fri, Mar 28, 2:19 PM
F15445457: D16038.id.diff
Thu, Mar 27, 2:01 PM
F15442902: D16038.diff
Thu, Mar 27, 1:11 AM
F15419832: D16038.diff
Fri, Mar 21, 9:16 AM
F15388643: D16038.id.diff
Sat, Mar 15, 4:11 AM
Unknown Object (File)
Feb 19 2025, 11:25 AM
Subscribers
None

Details

Summary

Ref T4103. This isn't completely perfect but should let us move forward without also expanding scope into "too much mail".

I split the existing "Mail Preferences" into two panels: a "Mail Delivery" panel for the EditEngine settings, and a "2000000 dropdowns" panel for the two million dropdowns. This one retains the old code more or less unmodified.

Test Plan
  • Ran unit tests, which cover most of this stuff.
  • Grepped for all removed constants.
  • Ran migrations, inspected database results.
  • Changed settings in both modified panels.
  • This covers a lot of ground, but anything I missed will hopefully be fairly obvious.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize all the mail preferences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 2:04 AM
This revision was automatically updated to reflect the committed changes.