Page MenuHomePhabricator

Modularize all the mail preferences
ClosedPublic

Authored by epriestley on Jun 4 2016, 11:23 PM.
Tags
None
Referenced Files
F18771523: D16038.id38588.diff
Wed, Oct 8, 8:11 PM
F18678768: D16038.diff
Thu, Sep 25, 11:17 PM
F18624925: D16038.id.diff
Sep 15 2025, 9:26 PM
F18616873: D16038.id.diff
Sep 14 2025, 7:19 PM
F18599169: D16038.diff
Sep 13 2025, 6:51 AM
F18500241: D16038.diff
Sep 4 2025, 8:36 PM
F18374832: D16038.id38604.diff
Aug 28 2025, 9:15 AM
F18373299: D16038.id38588.diff
Aug 28 2025, 7:23 AM
Subscribers
None

Details

Summary

Ref T4103. This isn't completely perfect but should let us move forward without also expanding scope into "too much mail".

I split the existing "Mail Preferences" into two panels: a "Mail Delivery" panel for the EditEngine settings, and a "2000000 dropdowns" panel for the two million dropdowns. This one retains the old code more or less unmodified.

Test Plan
  • Ran unit tests, which cover most of this stuff.
  • Grepped for all removed constants.
  • Ran migrations, inspected database results.
  • Changed settings in both modified panels.
  • This covers a lot of ground, but anything I missed will hopefully be fairly obvious.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize all the mail preferences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 2:04 AM
This revision was automatically updated to reflect the committed changes.