Differential D16037

Resolve timezone conflicts in a modern transactional way
ClosedPublic
Actions

Authored by epriestley on Jun 4 2016, 10:10 PM.

Details

Reviewers

chad

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rPd326b239aeea: Resolve timezone conflicts in a modern transactional way

Summary

Ref T4103. Also get rid of the weird cache clear that nothing else uses and which we don't actually need.

Test Plan

Resolved timezone conflict by ignoring it.
Resolved timezone conflict by picking a valid timezone.

Diff Detail

Repository

rP Phabricator

Branch

setting26

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12458
Build 15782: Run Core Tests
Build 15781: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38587.Jun 4 2016, 10:10 PM

epriestley retitled this revision from to Resolve timezone conflicts in a modern transactional way.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 4 2016, 10:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 4 2016, 10:38 PM

Closed by commit rPd326b239aeea: Resolve timezone conflicts in a modern transactional way (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 3:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

14 lines

settings/

controller/

PhabricatorSettingsTimezoneController.php

43 lines

Diff 38587

View Options

src/applications/people/storage/PhabricatorUser.php