Page MenuHomePhabricator
Differential D16036

Allow users to turn off desktop notifications
ClosedPublic
Actions

Authored by epriestley on Jun 4 2016, 10:02 PM.
Tags
None
Referenced Files
F13189890: D16036.diff
Sat, May 11, 6:31 AM
Unknown Object (File)
Tue, May 7, 10:15 AM
Unknown Object (File)
Fri, May 3, 10:20 AM
Unknown Object (File)
Thu, Apr 25, 3:47 AM
Unknown Object (File)
Fri, Apr 19, 4:48 PM
Unknown Object (File)
Wed, Apr 17, 9:15 AM
Unknown Object (File)
Apr 11 2024, 10:56 AM
Unknown Object (File)
Apr 7 2024, 11:23 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
T8846: Unable to turn off Desktop Notifications
Commits
rP9d7c28625240: Allow users to turn off desktop notifications
Summary

Fixes T8846. Ref T4103. I just took the shortest reasonable path here, this panel could use some attention on the next Conpherence iteration.

Test Plan

Turned on/off desktop notifications. Observed corresponding behavior in test notifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38586.Jun 4 2016, 10:02 PM
epriestley retitled this revision from to Allow users to turn off desktop notifications.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T8846: Unable to turn off Desktop Notifications, T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 4 2016, 10:13 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2016, 10:13 PM
Closed by commit rP9d7c28625240: Allow users to turn off desktop notifications (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38602

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/notification/builder/PhabricatorNotificationBuilder.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationIndividualController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorDesktopNotificationsSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanel.php

Loading...
View Options

src/applications/settings/setting/PhabricatorDesktopNotificationsSetting.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
Phabricator · Built by Phacility