Paths

Table of Contentst

Differential D16035

Use transactions to apply Ajax settings mutations
ClosedPublic
Actions

Authored by epriestley on Jun 4 2016, 9:47 PM.

Details

Reviewers

chad

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rP6199e95577c9: Use transactions to apply Ajax settings mutations

Summary

Ref T4103. Some settings (mostly nav collapsed/expanded states) use this endpoint to make adjustments when users press keys (like \ to toggle the durable column).

All of these settings are now formal, so swap things over to transactions.

Test Plan

Collapsed/expanded various navs, reloaded pages, settings stuck.

Diff Detail

Repository

rP Phabricator

Branch

setting24

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12456
Build 15778: Run Core Tests
Build 15777: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38585.Jun 4 2016, 9:47 PM

epriestley retitled this revision from to Use transactions to apply Ajax settings mutations.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 4 2016, 9:57 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 4 2016, 9:57 PM

Closed by commit rP6199e95577c9: Use transactions to apply Ajax settings mutations (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 3:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

controller/

PhabricatorSettingsAdjustController.php

22 lines

Diff 38585

View Options

src/applications/settings/controller/PhabricatorSettingsAdjustController.php

Use transactions to apply Ajax settings mutationsClosedPublicActions