Differential D16030

When a user enables/disables DarkConsole, forget their console UI visibility setting
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 7:14 PM.

Details

Reviewers

chad

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rP804e7a6e065a: When a user enables/disables DarkConsole, forget their console UI visibility…

Summary

Ref T4103. This primarily makes sure the console gets turned on when you enable it so you aren't like "where's the console???"

Test Plan

Enabled console, saw console.

Diff Detail

Repository

rP Phabricator

Branch

setting20

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12430
Build 15747: Run Core Tests
Build 15746: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38561.Jun 3 2016, 7:14 PM

epriestley retitled this revision from to When a user enables/disables DarkConsole, forget their console UI visibility setting.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 3 2016, 7:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2016, 7:15 PM

Closed by commit rP804e7a6e065a: When a user enables/disables DarkConsole, forget their console UI visibility… (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

setting/

PhabricatorDarkConsoleSetting.php

12 lines

Diff 38561

View Options

src/applications/settings/setting/PhabricatorDarkConsoleSetting.php

When a user enables/disables DarkConsole, forget their console UI visibility settingClosedPublicActions