Ref T4103. These settings long-predate proper settings and are based on hard-coded user properties. Turn them into real settings.
(I didn't try to migrate the value since they're trivial to restore and only useful to developers.)
Details
Details
- Toggled console on/off.
- Swapped tabs.
- Reloaded page, everything stayed sticky.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I wonder if this could replace darkconsole.always-on since one could turn it on for the 'logged out' or 'default' profile? Just a thought.
Comment Actions
I expect to be able to be able to get rid of at least a few other settings like metamta.vary-subjects and metamta.re-prefix and just move them to the global profile.
Stuff like darkconsole.always-on and phabricator.timezone might be removable too, but they enable slightly different behavior than a global default would and may have some boostrapping issues (e.g., we might emit a log early on that needs the timezone defined, before we have a chance to build it from storage).