Page MenuHomePhabricator
Differential D16024

Remove standalone huge single page setting edit controller
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 1:46 PM.
Tags
None
Referenced Files
F13223797: D16024.diff
Sun, May 19, 5:01 AM
F13205791: D16024.diff
Wed, May 15, 2:23 AM
F13205790: D16024.diff
Wed, May 15, 2:23 AM
F13189866: D16024.diff
Sat, May 11, 6:30 AM
Unknown Object (File)
Tue, May 7, 7:47 AM
Unknown Object (File)
Fri, May 3, 10:19 AM
Unknown Object (File)
Sun, Apr 28, 10:51 AM
Unknown Object (File)
Thu, Apr 25, 3:46 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
Commits
rP9a076b71a3a6: Remove standalone huge single page setting edit controller
Summary

Ref T4103. This isn't necessary or particularly useful anymore since panels have been converted.

Test Plan

Visited URI, got a 404.

Diff Detail

Repository
rP Phabricator
Branch
setting14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12424
Build 15735: Run Core Tests
Build 15734: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38555.Jun 3 2016, 1:46 PM
epriestley retitled this revision from to Remove standalone huge single page setting edit controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 3 2016, 6:56 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 6:56 PM
Closed by commit rP9a076b71a3a6: Remove standalone huge single page setting edit controller (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
settings/
application/
2 lines
controller/

Diff 38555

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/settings/application/PhabricatorSettingsApplication.php

Loading...
View Options

src/applications/settings/controller/PhabricatorSettingsEditController.php

Loading...
Phabricator · Built by Phacility