Differential D16023

Use EditEngine for diff, display, developer and most email settings
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 1:43 PM.

Details

Reviewers

chad

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rP45f347fe4777: Use EditEngine for diff, display, developer and most email settings

Summary

Ref T4103. This converts other straightforward panels to modern stuff.

Test Plan

Edited various settings.
Tried to set a bogus editor value.

Diff Detail

Repository

rP Phabricator

Branch

setting13

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12423
Build 15733: Run Core Tests
Build 15732: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38554.Jun 3 2016, 1:43 PM

epriestley retitled this revision from to Use EditEngine for diff, display, developer and most email settings.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 3 2016, 6:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2016, 6:03 PM

Closed by commit rP45f347fe4777: Use EditEngine for diff, display, developer and most email settings (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

8 lines

applications/

settings/

panel/

PhabricatorDeveloperPreferencesSettingsPanel.php

87 lines

PhabricatorDiffPreferencesSettingsPanel.php

94 lines

PhabricatorDisplayPreferencesSettingsPanel.php

188 lines

PhabricatorEmailFormatSettingsPanel.php

216 lines

setting/

PhabricatorAccessibilitySetting.php

10 lines

PhabricatorDarkConsoleSetting.php

12 lines

PhabricatorEditorMultipleSetting.php

8 lines

PhabricatorEditorSetting.php

31 lines

PhabricatorEmailFormatSetting.php

12 lines

PhabricatorEmailRePrefixSetting.php

12 lines

PhabricatorEmailVarySubjectsSetting.php

12 lines

PhabricatorMonospacedFontSetting.php

8 lines

PhabricatorMonospacedTextareasSetting.php

8 lines

PhabricatorOlderInlinesSetting.php

8 lines

PhabricatorShowFiletreeSetting.php

8 lines

PhabricatorTitleGlyphsSetting.php

8 lines

PhabricatorUnifiedDiffsSetting.php

8 lines

Diff 38554

View Options

src/__phutil_library_map__.php

View Options

src/applications/settings/panel/PhabricatorDeveloperPreferencesSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php

View Options

src/applications/settings/setting/PhabricatorAccessibilitySetting.php

View Options

src/applications/settings/setting/PhabricatorDarkConsoleSetting.php

View Options

src/applications/settings/setting/PhabricatorEditorMultipleSetting.php

View Options

src/applications/settings/setting/PhabricatorEditorSetting.php

View Options

src/applications/settings/setting/PhabricatorEmailFormatSetting.php

View Options

src/applications/settings/setting/PhabricatorEmailRePrefixSetting.php

View Options

src/applications/settings/setting/PhabricatorEmailVarySubjectsSetting.php

View Options

src/applications/settings/setting/PhabricatorMonospacedFontSetting.php

View Options

src/applications/settings/setting/PhabricatorMonospacedTextareasSetting.php

View Options

src/applications/settings/setting/PhabricatorOlderInlinesSetting.php

View Options

src/applications/settings/setting/PhabricatorShowFiletreeSetting.php

View Options

src/applications/settings/setting/PhabricatorTitleGlyphsSetting.php

View Options

src/applications/settings/setting/PhabricatorUnifiedDiffsSetting.php

Use EditEngine for diff, display, developer and most email settingsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38554

src/__phutil_library_map__.php

src/applications/settings/panel/PhabricatorDeveloperPreferencesSettingsPanel.php

src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php

src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php

src/applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php

src/applications/settings/setting/PhabricatorAccessibilitySetting.php

src/applications/settings/setting/PhabricatorDarkConsoleSetting.php

src/applications/settings/setting/PhabricatorEditorMultipleSetting.php

src/applications/settings/setting/PhabricatorEditorSetting.php

src/applications/settings/setting/PhabricatorEmailFormatSetting.php

src/applications/settings/setting/PhabricatorEmailRePrefixSetting.php

src/applications/settings/setting/PhabricatorEmailVarySubjectsSetting.php

src/applications/settings/setting/PhabricatorMonospacedFontSetting.php

src/applications/settings/setting/PhabricatorMonospacedTextareasSetting.php

src/applications/settings/setting/PhabricatorOlderInlinesSetting.php

src/applications/settings/setting/PhabricatorShowFiletreeSetting.php

src/applications/settings/setting/PhabricatorTitleGlyphsSetting.php

src/applications/settings/setting/PhabricatorUnifiedDiffsSetting.php

Use EditEngine for diff, display, developer and most email settings
ClosedPublic
Actions

Revision Contents
Changeset List