Page MenuHomePhabricator
Differential D16022

Use EditEngine for Conpherence preferences
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 1:16 PM.
Tags
None
Referenced Files
F18288638: D16022.diff
Sat, Aug 23, 8:29 AM
F18284035: D16022.id38574.diff
Sat, Aug 23, 2:26 AM
F18284034: D16022.id38553.diff
Sat, Aug 23, 2:26 AM
F18235765: D16022.diff
Wed, Aug 20, 7:45 PM
F18093057: D16022.id38574.diff
Thu, Aug 7, 3:06 PM
F18089981: D16022.id38574.diff
Wed, Aug 6, 1:38 PM
F18086114: D16022.id.diff
Tue, Aug 5, 7:34 PM
F17915747: D16022.id.diff
Tue, Jul 29, 9:02 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
Commits
rPef28adae9ac2: Use EditEngine for Conpherence preferences
Summary

Ref T4103. Only trick here is hiding the panel if Conpherence is not installed.

Test Plan
  • Edited Conpherence preferences.
  • Uninstalled Conpherence, saw panel vanish.

Diff Detail

Repository
rP Phabricator
Branch
setting12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12422
Build 15731: Run Core Tests
Build 15730: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38553.Jun 3 2016, 1:16 PM
epriestley retitled this revision from to Use EditEngine for Conpherence preferences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 3 2016, 6:02 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 6:02 PM
Closed by commit rPef28adae9ac2: Use EditEngine for Conpherence preferences (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38553

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/settings/controller/PhabricatorSettingsMainController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorEditEngineSettingsPanel.php

Loading...
View Options

src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php

Loading...
Phabricator · Built by Phacility