Page MenuHomePhabricator
Differential D16014

Modularize Conpherence notification preferences
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 12:02 AM.
Tags
None
Referenced Files
F13136740: D16014.diff
Thu, May 2, 3:26 PM
Unknown Object (File)
Thu, Apr 25, 1:43 AM
Unknown Object (File)
Wed, Apr 24, 9:35 PM
Unknown Object (File)
Fri, Apr 19, 4:46 PM
Unknown Object (File)
Thu, Apr 11, 9:31 AM
Unknown Object (File)
Mon, Apr 8, 8:01 AM
Unknown Object (File)
Mar 31 2024, 11:39 PM
Unknown Object (File)
Mar 31 2024, 3:46 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
Commits
rP57c2f61b7597: Modularize Conpherence notification preferences
Summary

Ref T4103. This is a weird standalone setting that I didn't clean up earlier.

Also fix an issue with the PronounSetting and the Editor not interacting properly.

Test Plan

Edited using new EditEngine UI.

Diff Detail

Repository
rP Phabricator
Branch
setting6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12412
Build 15715: Run Core Tests
Build 15714: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38541.Jun 3 2016, 12:02 AM
epriestley retitled this revision from to Modularize Conpherence notification preferences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 3 2016, 12:46 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 12:46 AM
Closed by commit rP57c2f61b7597: Modularize Conpherence notification preferences (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38541

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/settings/editor/PhabricatorUserPreferencesEditor.php

Loading...
View Options

src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php

Loading...
Phabricator · Built by Phacility