Differential D16000

Add information dialogs to adding project members if unsupported
ClosedPublic
Actions

Authored by chad on Jun 1 2016, 7:34 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11055: Parent Project membership editing sometimes unclear

Commits

rP7126025fe637: Add information dialogs to adding project members if unsupported

Summary

If you try to join or add members to a parent project, we currently return 404. This instead adds an informational dialog. Fixes T11055

Test Plan

Click on Join Project and Add Members while on a Parent Project or Milestone.

Diff Detail

Repository

rP Phabricator

Branch

project-dialogs (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12386
Build 15677: Run Core Tests
Build 15676: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38510.Jun 1 2016, 7:34 PM

chad retitled this revision from to Add information dialogs to adding project members if unsupported.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11055: Parent Project membership editing sometimes unclear.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 1 2016, 7:34 PM

epriestley accepted this revision.Jun 1 2016, 7:40 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 1 2016, 7:40 PM

Closed by commit rP7126025fe637: Add information dialogs to adding project members if unsupported (authored by chad, committed by chad). · Explain WhyJun 1 2016, 7:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectMembersAddController.php

11 lines

PhabricatorProjectUpdateController.php

12 lines

Diff 38510

View Options

src/applications/project/controller/PhabricatorProjectMembersAddController.php