Page MenuHomePhabricator

Fix top margin on infoview + two-column
ClosedPublic

Authored by chad on May 31 2016, 7:05 PM.
Tags
None
Referenced Files
F13152562: D15992.diff
Sat, May 4, 8:15 PM
Unknown Object (File)
Wed, May 1, 1:04 AM
Unknown Object (File)
Mon, Apr 8, 8:47 PM
Unknown Object (File)
Mar 31 2024, 11:36 PM
Unknown Object (File)
Mar 31 2024, 11:36 PM
Unknown Object (File)
Mar 17 2024, 5:30 AM
Unknown Object (File)
Mar 6 2024, 11:56 AM
Unknown Object (File)
Mar 1 2024, 11:34 AM
Subscribers

Details

Summary

When you save settings or don't have reviewers, we show an info box inside an object box. This rule is squashing the margin. Blame seems to indicate I added it for Differential updates, but in re-visiting Differential, I'm unable to trigger any broken CSS with this change. But keep an eye out?

Test Plan

Badges, Settings, Differential

Diff Detail

Repository
rP Phabricator
Branch
info-box (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12370
Build 15653: Run Core Tests
Build 15652: arc lint + arc unit

Event Timeline

chad retitled this revision from to Fix top margin on infoview + two-column.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 31 2016, 7:05 PM
This revision was automatically updated to reflect the committed changes.