Differential D15992

Fix top margin on infoview + two-column
ClosedPublic
Actions

Authored by chad on May 31 2016, 7:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 6:42 PM

	Unknown Object (File)
	Thu, Dec 19, 2:27 PM

	Unknown Object (File)
	Sat, Dec 14, 4:01 AM

	Unknown Object (File)
	Thu, Dec 12, 10:47 PM

	Unknown Object (File)
	Thu, Dec 12, 10:47 PM

	Unknown Object (File)
	Sat, Dec 7, 11:07 AM

	Unknown Object (File)
	Nov 20 2024, 2:37 PM

	Unknown Object (File)
	Nov 16 2024, 12:44 PM

Subscribers

Details

Reviewers

Commits

rPe64dfbcbd85f: Fix top margin on infoview + two-column

Summary

When you save settings or don't have reviewers, we show an info box inside an object box. This rule is squashing the margin. Blame seems to indicate I added it for Differential updates, but in re-visiting Differential, I'm unable to trigger any broken CSS with this change. But keep an eye out?

Test Plan

Badges, Settings, Differential

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38493.May 31 2016, 7:05 PM

chad retitled this revision from to Fix top margin on infoview + two-column.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMay 31 2016, 7:05 PM

epriestley accepted this revision.May 31 2016, 7:05 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 31 2016, 7:05 PM

Closed by commit rPe64dfbcbd85f: Fix top margin on infoview + two-column (authored by chad, committed by chad). · Explain WhyMay 31 2016, 7:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

webroot/

rsrc/

css/

phui/

phui-two-column-view.css

4 lines

Diff 38494

resources/celerity/map.php

Loading...

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...