Allow broader HTTP access to public repositories, respect nonstandard Phabricator HTTP port when generating repository URIs
ClosedPublic
Actions

Authored by epriestley on May 25 2016, 3:10 PM.

Details

Reviewers

Maniphest Tasks

T11030: Cannot clone public repository over HTTP anonymously.
T11032: Repository URL missing port if phabricator is installed on non-80 port

Commits

rP189600e4116e: Allow broader HTTP access to public repositories, respect nonstandard…

Summary

Fixes T11030. Fixes T11032.

Allow HTTP access to "Public" repositories even if diffusion.allow-http-auth is disabled.
If you run Phabricator on an unusual port (???) use that port as the default when generating HTTP URIs.

Test Plan

Faked phabricator.base-uri to an unusual port, saw repository HTTP URI generate with an unusual port.
Disabled diffusion.allow-http-auth, confirmed that toggling view policy between "public" and "users" activated or deactivated HTTP clone URI.

Diff Detail

Repository

rP Phabricator

Branch

dx2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12329
Build 15593: Run Core Tests
Build 15592: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38454.May 25 2016, 3:10 PM

epriestley retitled this revision from to Allow broader HTTP access to public repositories, respect nonstandard Phabricator HTTP port when generating repository URIs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T11032: Repository URL missing port if phabricator is installed on non-80 port, T11030: Cannot clone public repository over HTTP anonymously..

chad accepted this revision.May 25 2016, 3:28 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 25 2016, 3:28 PM

Closed by commit rP189600e4116e: Allow broader HTTP access to public repositories, respect nonstandard… (authored by epriestley, committed by epriestley). · Explain WhyMay 25 2016, 4:07 PM

This revision was automatically updated to reflect the committed changes.