Page MenuHomePhabricator

Allow broader HTTP access to public repositories, respect nonstandard Phabricator HTTP port when generating repository URIs
ClosedPublic

Authored by epriestley on May 25 2016, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 11:30 PM
Unknown Object (File)
Tue, Mar 5, 7:49 AM
Unknown Object (File)
Feb 23 2024, 7:20 AM
Unknown Object (File)
Feb 14 2024, 10:39 AM
Unknown Object (File)
Feb 14 2024, 7:53 AM
Unknown Object (File)
Feb 14 2024, 7:52 AM
Unknown Object (File)
Feb 9 2024, 1:56 PM
Unknown Object (File)
Feb 8 2024, 5:28 AM
Subscribers
None

Details

Summary

Fixes T11030. Fixes T11032.

  • Allow HTTP access to "Public" repositories even if diffusion.allow-http-auth is disabled.
  • If you run Phabricator on an unusual port (???) use that port as the default when generating HTTP URIs.
Test Plan
  • Faked phabricator.base-uri to an unusual port, saw repository HTTP URI generate with an unusual port.
  • Disabled diffusion.allow-http-auth, confirmed that toggling view policy between "public" and "users" activated or deactivated HTTP clone URI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow broader HTTP access to public repositories, respect nonstandard Phabricator HTTP port when generating repository URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 25 2016, 3:28 PM
This revision was automatically updated to reflect the committed changes.