Differential D15971

Fix expansion of projects into lists of user PHIDs
ClosedPublic
Actions

Authored by epriestley on May 24 2016, 1:08 PM.

Tags

None

Referenced Files

	F14737142: D15971.diff
	Sun, Jan 19, 3:26 AM

	Unknown Object (File)
	Thu, Jan 16, 11:09 AM

	Unknown Object (File)
	Sat, Jan 11, 12:33 AM

	Unknown Object (File)
	Sun, Jan 5, 10:42 AM

	Unknown Object (File)
	Tue, Dec 31, 7:57 PM

	Unknown Object (File)
	Fri, Dec 27, 11:57 PM

	Unknown Object (File)
	Wed, Dec 25, 3:37 PM

	Unknown Object (File)
	Wed, Dec 25, 2:57 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11016: When owner of Owners package is a project, audit triggers even when member of project signs off

Commits

rPd1eed54d85bc: Fix expansion of projects into lists of user PHIDs

Summary

Ref T11016. I think I inverted the meaning of this function by accident in D14893.

The intent is to return a list of users: direct users, and all members of all projects.

Prior to this patch actually returns direct users, and all projects they are members of.

Test Plan

Created "Project with Dog".
Added user "dog" to project.
Created package "X", owning file "/x", with audit enabled.
Made "X" owned by "Project with Dog".
Modified "/x" and had user "dog" accept it.
Landed change.
Prior to change: package "X" incorrectly added as auditor.
After change: package "X" correctly omitted as auditor, because a member reviewed the change.

Diff Detail

Repository

Branch

owners1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12326
Build 15589: Run Core Tests
Build 15588: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38451.May 24 2016, 1:08 PM

epriestley retitled this revision from to Fix expansion of projects into lists of user PHIDs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.

epriestley mentioned this in T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.May 24 2016, 1:09 PM

chad accepted this revision.May 24 2016, 1:37 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 24 2016, 1:37 PM

Closed by commit rPd1eed54d85bc: Fix expansion of projects into lists of user PHIDs (authored by epriestley, committed by epriestley). · Explain WhyMay 24 2016, 1:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

storage/

PhabricatorOwnersOwner.php

38 lines

Diff 38451

src/applications/owners/storage/PhabricatorOwnersOwner.php

Loading...