Page MenuHomePhabricator

Fix expansion of projects into lists of user PHIDs
ClosedPublic

Authored by epriestley on May 24 2016, 1:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 26, 5:00 AM
Unknown Object (File)
Wed, Nov 23, 3:49 AM
Unknown Object (File)
Mon, Nov 14, 12:23 PM
Unknown Object (File)
Thu, Nov 10, 12:51 PM
Unknown Object (File)
Sun, Nov 6, 7:53 PM
Unknown Object (File)
Fri, Nov 4, 5:50 AM
Unknown Object (File)
Oct 31 2022, 8:55 PM
Unknown Object (File)
Oct 31 2022, 5:57 PM
Subscribers
None

Details

Summary

Ref T11016. I think I inverted the meaning of this function by accident in D14893.

The intent is to return a list of users: direct users, and all members of all projects.

Prior to this patch actually returns direct users, and all projects they are members of.

Test Plan
  • Created "Project with Dog".
  • Added user "dog" to project.
  • Created package "X", owning file "/x", with audit enabled.
  • Made "X" owned by "Project with Dog".
  • Modified "/x" and had user "dog" accept it.
  • Landed change.
  • Prior to change: package "X" incorrectly added as auditor.
  • After change: package "X" correctly omitted as auditor, because a member reviewed the change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix expansion of projects into lists of user PHIDs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 24 2016, 1:37 PM
This revision was automatically updated to reflect the committed changes.