Fix "Reviewers" validation issue with empty reviewers
ClosedPublic
Actions

Authored by epriestley on May 24 2016, 12:06 AM.

Details

Reviewers

Maniphest Tasks

T11021: Argument 1 passed to DifferentialReviewersField::inflateReviewers() must be of the type array, null given

Commits

rP70b194398e45: (stable) Fix "Reviewers" validation issue with empty reviewers
rP725d60eb4aa8: Fix "Reviewers" validation issue with empty reviewers

Summary

Fixes T11021.

Test Plan

Created a revision without reviewers.

Diff Detail

Repository

rP Phabricator

Branch

dx2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12320
Build 15580: Run Core Tests
Build 15579: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38445.May 24 2016, 12:06 AM

epriestley retitled this revision from to Fix "Reviewers" validation issue with empty reviewers.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11021: Argument 1 passed to DifferentialReviewersField::inflateReviewers() must be of the type array, null given.

chad accepted this revision.May 24 2016, 12:07 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 24 2016, 12:07 AM

Closed by commit rP725d60eb4aa8: Fix "Reviewers" validation issue with empty reviewers (authored by epriestley, committed by epriestley). · Explain WhyMay 24 2016, 12:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialReviewersField.php

4 lines

Diff 38445

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Fix "Reviewers" validation issue with empty reviewersClosedPublicActions