Fix one more "Reviewers" wire format issue
ClosedPublic
Actions

Authored by epriestley on May 23 2016, 5:43 PM.

Details

Reviewers

Maniphest Tasks

T11010: Http502 when submitting or updating a diff

Commits

rP08cc80cc5ce0: (stable) Fix one more "Reviewers" wire format issue
rPe1ad312fdd2c: Fix one more "Reviewers" wire format issue

Summary

Fixes T11010. This also needs to be inflated until we fix the whole client/server responsibility issue here.

Test Plan

Created a revision while observing error log, no error.
Disabled "allow self accept", tried to make myself a reviewer, got rejected with an error message.

Diff Detail

Repository

rP Phabricator

Branch

dx1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12315
Build 15573: Run Core Tests
Build 15572: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38440.May 23 2016, 5:43 PM

epriestley retitled this revision from to Fix one more "Reviewers" wire format issue.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11010: Http502 when submitting or updating a diff.

chad accepted this revision.May 23 2016, 5:58 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 23 2016, 5:58 PM

Closed by commit rPe1ad312fdd2c: Fix one more "Reviewers" wire format issue (authored by epriestley, committed by epriestley). · Explain WhyMay 23 2016, 7:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialReviewersField.php

1 line

Diff 38440

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Fix one more "Reviewers" wire format issueClosedPublicActions