Differential D15965

Wordsmith the timezone selection UX
ClosedPublic
Actions

Authored by epriestley on May 23 2016, 5:28 PM.

Details

Reviewers

chad

Maniphest Tasks

T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them

Commits

rPefd001b42fd5: Wordsmith the timezone selection UX

Summary

Ref T3025.

Show current zone to make the current vs new more clear.
Tweak some text.

Test Plan

Screen Shot 2016-05-23 at 10.27.22 AM.png (255×612 px, 31 KB)

Diff Detail

Repository

rP Phabricator

Branch

tz3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12312
Build 15569: Run Core Tests
Build 15568: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38437.May 23 2016, 5:28 PM

epriestley retitled this revision from to Wordsmith the timezone selection UX.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

chad accepted this revision.May 23 2016, 5:29 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 23 2016, 5:29 PM

Closed by commit rPefd001b42fd5: Wordsmith the timezone selection UX (authored by epriestley, committed by epriestley). · Explain WhyMay 23 2016, 5:31 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.May 23 2016, 5:36 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

controller/

PhabricatorSettingsTimezoneController.php

12 lines

view/

page/

PhabricatorStandardPageView.php

2 lines

Diff 38437

View Options

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php