Page MenuHomePhabricator

Detect timezone discrepancies and prompt users to reconcile them
ClosedPublic

Authored by epriestley on May 21 2016, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 7:59 AM
Unknown Object (File)
Mon, Apr 8, 12:54 AM
Unknown Object (File)
Sun, Mar 31, 4:46 PM
Unknown Object (File)
Sun, Mar 31, 4:45 PM
Unknown Object (File)
Sun, Mar 31, 4:45 PM
Unknown Object (File)
Sun, Mar 24, 9:36 AM
Unknown Object (File)
Mar 11 2024, 7:13 AM
Unknown Object (File)
Feb 18 2024, 3:13 PM
Subscribers
None

Details

Summary

Ref T3025. This adds a check for different client/server timezone offsets and gives users an option to fix them or ignore them.

Test Plan
  • Fiddled with timezone in Settings and System Preferences.
  • Got appropriate prompts and behavior after simulating various trips to and from exotic locales.

In particular, this slightly tricky case seems to work correctly:

  • Travel to NY.
  • Ignore discrepancy (you're only there for a couple hours for an important meeting, and returning to SF on a later flight).
  • Return to SF for a few days.
  • Travel back to NY.
  • You should be prompted again, since you left the timezone after you ignored the discrepancy.

Screen Shot 2016-05-21 at 3.08.53 PM.png (722×1 px, 90 KB)

Screen Shot 2016-05-21 at 3.09.08 PM.png (615×1 px, 125 KB)

Screen Shot 2016-05-21 at 3.09.23 PM.png (722×1 px, 89 KB)

Diff Detail

Repository
rP Phabricator
Branch
tz1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/core/behavior-detect-timezone.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 12301
Build 15552: Run Core Tests
Build 15551: arc lint + arc unit