Page MenuHomePhabricator

Use new Differential bucketing logic on default (non-dashboard) homepage
ClosedPublic

Authored by epriestley on May 19 2016, 8:32 PM.

Details

Summary

Ref T10939. If you haven't installed a dashboard, we show an "Active Revisions" panel on the homepage by default. I waited a bit to update this, but the new buckets don't seem to have caused any major problems so far.

Update this to use the new logic. I'm just showing "must review" + "should review", which is similar to the old beahvior.

Also replace the notification count with this same number. This is a little different from the old behavior, but simpler, and I think we should probably move toward getting rid of these counts completely.

Test Plan
  • Viewed homepage as logged-in user, saw my revisions (including revisions I have authority over only because of project membership).
  • Saw consistent notification count.
  • Grepped for removed method.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38404.May 19 2016, 8:32 PM
epriestley retitled this revision from to Use new Differential bucketing logic on default (non-dashboard) homepage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.May 19 2016, 10:07 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 10:07 PM
This revision was automatically updated to reflect the committed changes.