Page MenuHomePhabricator

Use transactions to apply web UI SSH key edits
ClosedPublic

Authored by epriestley on May 19 2016, 5:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 3:43 AM
Unknown Object (File)
Wed, Apr 24, 3:43 AM
Unknown Object (File)
Wed, Apr 24, 3:43 AM
Unknown Object (File)
Wed, Apr 24, 3:43 AM
Unknown Object (File)
Fri, Apr 19, 4:42 PM
Unknown Object (File)
Thu, Apr 11, 9:38 AM
Unknown Object (File)
Mon, Apr 8, 9:58 PM
Unknown Object (File)
Mon, Apr 1, 11:09 AM
Subscribers
None

Details

Summary

Ref T10917. Converts web UI edits to transactions.

This is about 95% "the right way", and then I cheated on the last 5% instead of building a real EditEngine. We don't need it for anything else right now and some of the dialog workflows here are a little weird so I'm just planning to skip it for the moment unless it ends up being easier to do after the next phase (mail notifications) or something like that.

Test Plan

Screen Shot 2016-05-19 at 10.12.48 AM.png (1×1 px, 157 KB)

Diff Detail

Repository
rP Phabricator
Branch
ssh3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12271
Build 15507: Run Core Tests
Build 15506: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use transactions to apply web UI SSH key edits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 9:50 PM
This revision was automatically updated to reflect the committed changes.