Page MenuHomePhabricator
Differential D15942

Special case the "added projects" transaction in mail when creating objects
ClosedPublic
Actions

Authored by epriestley on May 18 2016, 1:58 PM.
Tags
None
Referenced Files
F13059706: D15942.diff
Fri, Apr 19, 4:42 PM
Unknown Object (File)
Wed, Apr 17, 2:13 PM
Unknown Object (File)
Wed, Apr 10, 11:08 PM
Unknown Object (File)
Wed, Apr 10, 6:27 PM
Unknown Object (File)
Mon, Apr 8, 9:41 AM
Unknown Object (File)
Fri, Mar 29, 6:07 AM
Unknown Object (File)
Mar 20 2024, 6:13 PM
Unknown Object (File)
Mar 20 2024, 5:33 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10493: Task creation no longer lists projects added (neither the UI nor mail notifications)
Commits
rP7b50eef27a56: Special case the "added projects" transaction in mail when creating objects
Summary

Fixes T10493. See that task and inline comments for discussion.

Test Plan

Created an object with some projects, saw the transaction in resulting mail:

Screen Shot 2016-05-18 at 6.57.02 AM.png (315×508 px, 39 KB)

Diff Detail

Repository
rP Phabricator
Branch
pcreate1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12255
Build 15485: Run Core Tests
Build 15484: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38383.May 18 2016, 1:58 PM
epriestley retitled this revision from to Special case the "added projects" transaction in mail when creating objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).
chad accepted this revision.May 18 2016, 2:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 18 2016, 2:05 PM
epriestley mentioned this in T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).May 18 2016, 2:07 PM
Closed by commit rP7b50eef27a56: Special case the "added projects" transaction in mail when creating objects (authored by epriestley, committed by epriestley). · Explain WhyMay 18 2016, 2:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
storage/
9 lines

Diff 38383

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility