Page MenuHomePhabricator

Improve audit behavior for "uninteresting" auditors

Authored by epriestley on May 17 2016, 7:01 PM.



Ref T10939. Fixes T10174. We can currently trigger "uninteresting" auditors in two ways:

  • Packages with auditing disabled ("NONE" audits).
  • Packages with auditing enabled, but they don't need an audit (e.g., author is a pacakge owner; "NOT REQUIRED" audits).

These audits aren't interesting (we only write them so we can list "commits in this package" from other UIs) but right now they take up the audit slot. In particular:

  • They show in the UI, but are generally useless/confusing nowadays. The actual table of contents does a better job of just showing "which packages do these paths belong to" now, and shows all packages for each path.
  • They block Herald from adding real auditors.

Change this:

  • Don't show uninteresting auditors.
  • Let Herald upgrade uninteresting auditors into real auditors.
Test Plan
  • Ran bin/repository reparse --owners <commit> --force, and --herald to trigger Owners and Herald rules.
  • With a package with auditing disabled, triggered a "None" audit and saw it no longer appear in the UI with the patch applied.
  • With a package with auditing disabled, added a Herald rule to trigger an audit. With the patch, saw it go through and upgrade the audit to "Audit Required".

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38377.May 17 2016, 7:01 PM
epriestley retitled this revision from to Improve audit behavior for "uninteresting" auditors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.May 17 2016, 8:15 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 17 2016, 8:15 PM
This revision was automatically updated to reflect the committed changes.