Page MenuHomePhabricator

Remove "days fresh" / "days stale" indictator in Differential revision list
ClosedPublic

Authored by epriestley on May 16 2016, 4:48 PM.

Details

Summary

Ref T10939. I'm not totally opposed to the existence of this element, but I think it's the kind of thing that would never make it upstream today. I think this should just be a T418 custom sort of thing in the long run, not a mainline upstream feature.

Overall, I think this thing is nearly useless and just adds visual clutter. My dashboard is about 100% red. This also sort of teaches users that it's fine to let revisions sit for a couple of days, which isn't what I'd like the UI to teach. Finally, removing it helps the UI feel a little less cluttered after the visually busy changes in D15926.

Test Plan

Grepped for removed config. Viewed revision list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove "days fresh" / "days stale" indictator in Differential revision list.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Specifically, this little colored clock is the removed element:

Screen Shot 2016-05-16 at 9.48.35 AM.png (431×248 px, 37 KB)

chad edited edge metadata.
This revision is now accepted and ready to land.May 16 2016, 5:01 PM
epriestley edited edge metadata.
  • Port the redundant text removal foward from D15926.
This revision was automatically updated to reflect the committed changes.

My dashboard is about 100% red. This also sort of teaches users that it's fine to let revisions sit for a couple of days, which isn't what I'd like the UI to teach.

Isn't that indicator there to say: no action was taken on this revision since 1 or since 3 days? If that is so, then in real world each revision should either be committed or closed. How is that possible, that revision stays without any activity for more than 3 days?

In controlled environment (e.g. at work) it's not possible, because people work and you know that work will be done.

In open source world the revision can quickly become stale due it's author no longer working on it and there is nothing that can be done here really. From that aspect I do agree with you that they needs to be hidden.