Page MenuHomePhabricator
Differential D15922

Fix `arc which` for svn repos
ClosedPublic
Actions

Authored by eadler on May 16 2016, 10:23 AM.
Tags
None
Referenced Files
F15529853: D15922.id38340.diff
Tue, Apr 22, 10:58 PM
F15518208: D15922.id.diff
Sat, Apr 19, 11:59 AM
F15514552: D15922.diff
Fri, Apr 18, 3:36 AM
F15503299: D15922.id38340.diff
Mon, Apr 14, 8:50 AM
F15499532: D15922.id38338.diff
Sun, Apr 13, 2:59 PM
F15469281: D15922.diff
Fri, Apr 4, 11:28 AM
F15422504: D15922.id38338.diff
Mar 22 2025, 8:53 AM
F15418375: D15922.id38340.diff
Mar 20 2025, 10:56 PM
View All Files
Subscribers
aik099
Korvin

Details

Reviewers
epriestley
aik099
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6635: The `arc which` command triggers notices
Commits
rARC0249f90a9a4a: (stable) Promote 2016 Week 21
rARC2234c8cacc21: Fix `arc which` for svn repos
Summary

arc which is currently broken for svn repos.

Fixes T6635

(I think I independently wrote an identical change to yours)

Test Plan

∴../../p/arcanist/bin/arc which on a svn repo.

Diff Detail

Repository
rARC Arcanist
Branch
eax/fix-svn-which
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 12212
Build 15420: Run Core Tests
Build 15419: arc lint + arc unit

Event Timeline

eadler updated this revision to Diff 38338.May 16 2016, 10:23 AM
eadler retitled this revision from to Fix `arc which` for svn repos.
eadler updated this object.
eadler edited the test plan for this revision. (Show Details)
eadler added a reviewer: epriestley.
eadler added a task: T6635: The `arc which` command triggers notices.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 16 2016, 10:23 AM
Herald added a subscriber: Korvin. · View Herald Transcript
aik099 accepted this revision.May 16 2016, 10:36 AM
aik099 added a reviewer: aik099.
aik099 added a subscriber: aik099.

I'm accepting this revision, because it's identical to https://secure.phabricator.com/differential/diff/26214/ diff created by @epriestley some time ago.

epriestley accepted this revision.May 16 2016, 12:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 16 2016, 12:18 PM
Closed by commit rARC2234c8cacc21: Fix `arc which` for svn repos (authored by epriestley, committed by eadler). · Explain WhyMay 16 2016, 12:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
repository/
api/
2 lines

Diff 38338

View Options

src/repository/api/ArcanistSubversionAPI.php

Loading...
Phabricator · Built by Phacility