Page MenuHomePhabricator

Use "fa-shopping-bag" instead of "fa-list-alt" for Owners package icon
ClosedPublic

Authored by epriestley on May 13 2016, 5:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 7:27 PM
Unknown Object (File)
Mon, Mar 18, 7:22 PM
Unknown Object (File)
Mon, Mar 18, 3:40 PM
Unknown Object (File)
Sun, Mar 17, 9:04 PM
Unknown Object (File)
Sun, Mar 17, 5:50 PM
Unknown Object (File)
Sat, Mar 16, 8:22 AM
Unknown Object (File)
Wed, Mar 13, 4:06 PM
Unknown Object (File)
Wed, Mar 13, 3:45 PM
Subscribers
None
Tokens
"Like" token, awarded by eadler.

Details

Summary

Ref T10939. These appear in "Subscribers" tokenizers now and we got a maybe slightly better icon in the last FA update: instead of .

(I don't feel strongly about this, the old icon just doesn't seem very evocative.)

Test Plan

o.( O___O ).o

Screen Shot 2016-05-13 at 10.45.09 AM.png (150×415 px, 17 KB)

Diff Detail

Repository
rP Phabricator
Branch
owners5b
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12189
Build 15388: Run Core Tests
Build 15387: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use "fa-shopping-bag" instead of "fa-list-alt" for Owners package icon.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

I thought it was , though maybe thats Owners in general.

This revision is now accepted and ready to land.May 13 2016, 7:29 PM

Ah, yeah, I think so. We should possibly make them consistent at some point -- we probably need something similar for T5055 eventually too, although maybe we'll get another round of FA updates by then.

This revision was automatically updated to reflect the committed changes.