Page MenuHomePhabricator

Consider packages when calculating Differential authority
ClosedPublic

Authored by epriestley on May 13 2016, 2:31 PM.

Details

Summary

Ref T10939. This has no effect yet since packages can not actually become reviewers, I'm just inching toward support.

  • When searching for "responsible users", include revisions that need review by packages you have authority over.
  • When calculating review authority, include authority over packages you are a member of (these currently never exist).
Test Plan

This isn't reachable so I just var_dump()'d stuff and looked at the generated queries, which appeared correct/reasonable.

I'll vet this more thoroughly once packages can actually become reviewers.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38313.May 13 2016, 2:31 PM
epriestley retitled this revision from to Consider packages when calculating Differential authority.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.May 13 2016, 2:57 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 2:57 PM
This revision was automatically updated to reflect the committed changes.