Fix an issue with URI index updates from the daemons
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 1:49 PM.

Details

Reviewers

chad

Maniphest Tasks

T10923: Diffusion API/URI Errata

Commits

rPdc2d87059b29: Fix an issue with URI index updates from the daemons

Summary

Ref T10923. This extension needs to load a little more data (with needURIs) to function correctly now.

(There's a recent migration does this, so indexes got updated correctly when it ran, so it hasn't been obvious that they weren't getting updated properly after that.)

Test Plan

Made an arbitrary edit to a repository, observed no more error in daemon logs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38310.May 13 2016, 1:49 PM

epriestley retitled this revision from to Fix an issue with URI index updates from the daemons.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10923: Diffusion API/URI Errata.

The exception looked something like this:

<<VERB>> PhabricatorTaskmasterDaemon Working on task 1190367 (PhabricatorSearchWorker)...
[2016-05-13 06:45:35] EXCEPTION: (PhutilProxyException) Permanent failure while executing Task ID 1190367. {>} (PhabricatorWorkerPermanentFailureException) Failed to update search index for document "PHID-REPO-i34pmj6av2r5y2xlecrl": Attempting to access attached data on PhabricatorRepository (via getURIs()), but the data is not actually attached. Before accessing attachable data on an object, you must load and attach it.

Data is normally attached by calling the corresponding needX() method on the Query class when the object is loaded. You can also call the corresponding attachX() method explicitly. at [<phabricator>/src/applications/search/worker/PhabricatorSearchWorker.php:54]
arcanist(head=master, ref.master=c58f1b9a2507), corgi(head=master, ref.master=cfed644883b0), instances(head=master, ref.master=cdb7c7f4ba51), ledger(head=master, ref.master=4da4a24b8779), libcore(), phabricator(head=uriindex, ref.master=1c73ad6a1bb0, ref.uriindex=1c73ad6a1bb0, custom=9), phutil(head=master, ref.master=b25e0477b280), services(head=master, ref.master=04ae8c8f8e3b)
  #0 <#2> PhabricatorSearchWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:122]
  #1 <#2> PhabricatorWorker::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:171]
  #2 <#2> PhabricatorWorkerActiveTask::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php:22]
  #3 PhabricatorTaskmasterDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:183]
  #4 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:125]

chad accepted this revision.May 13 2016, 1:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 13 2016, 1:50 PM

Closed by commit rPdc2d87059b29: Fix an issue with URI index updates from the daemons (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2016, 1:51 PM

This revision was automatically updated to reflect the committed changes.